Subscribe to On github feed
Updated: 2 min 54 sec ago

clemens-tolboom opened a pull request in finepointcgi/Godot-Open-AI-GPT-Integration

Fri, 2023/06/16 - 3:56pm
clemens-tolboom opened finepointcgi/Godot-Open-AI-GPT-Integration#4 · June 16, 2023 13:56 Auto create settings.json if not exists #4

Fixes error res://addons/GPTIntegration/GPTIntegration.gd:225 - Attempt to call function 'get_as_text' in base 'null instance' on a null instance. …

+11 -2

clemens-tolboom commented on pull request MikeSchulze/gdUnit4#214

Fri, 2023/06/16 - 3:48pm
clemens-tolboom commented on MikeSchulze/gdUnit4#214 · June 16, 2023 13:48 clemens-tolboom commented Jun 16, 2023

LGTM :-) I miss the direct linking to the steps but that is your call. Maybe mention your numbering convention on issue titles? And you project(s) …

clemens-tolboom commented on pull request MikeSchulze/gdUnit4#207

Fri, 2023/06/16 - 10:01am
clemens-tolboom commented on MikeSchulze/gdUnit4#207 · June 16, 2023 08:01 clemens-tolboom commented Jun 16, 2023

Can't this go into one of the PR steps? Step 5 maybe? Ensure your code follows GDScript or C# Coding Conventions

clemens-tolboom commented on pull request MikeSchulze/gdUnit4#207

Fri, 2023/06/16 - 9:58am
clemens-tolboom commented on MikeSchulze/gdUnit4#207 · June 16, 2023 07:58 clemens-tolboom commented Jun 16, 2023

I think this section can go way up :-)

clemens-tolboom commented on pull request MikeSchulze/gdUnit4#207

Fri, 2023/06/16 - 9:57am
clemens-tolboom commented on MikeSchulze/gdUnit4#207 · June 16, 2023 07:57 clemens-tolboom commented Jun 16, 2023

If you make the list below H3 or H4 you can direct link in the future to particular items giving better pointers to contributors IMHO

clemens-tolboom commented on pull request MikeSchulze/gdUnit4#207

Fri, 2023/06/16 - 9:55am
clemens-tolboom commented on MikeSchulze/gdUnit4#207 · June 16, 2023 07:55 clemens-tolboom commented Jun 16, 2023

All code changes starts from an issue. (that was the whole point of this #204 ;-) )

clemens-tolboom commented on pull request MikeSchulze/gdUnit4#207

Fri, 2023/06/16 - 9:54am
clemens-tolboom commented on MikeSchulze/gdUnit4#207 · June 16, 2023 07:54 clemens-tolboom commented Jun 16, 2023

I never heard of GitHub Flow ... can this be linked to a blog or docs?

clemens-tolboom commented on pull request MikeSchulze/gdUnit4#207

Fri, 2023/06/16 - 9:52am
clemens-tolboom commented on MikeSchulze/gdUnit4#207 · June 16, 2023 07:52 clemens-tolboom commented Jun 16, 2023

It's recommended to familiarize yourself with GitHub's features and workflow I guess our users are savvy git users but maybe not GitHub? What fea…

clemens-tolboom commented on pull request MikeSchulze/gdUnit4#207

Fri, 2023/06/16 - 9:52am
clemens-tolboom commented on MikeSchulze/gdUnit4#207 · June 16, 2023 07:52 clemens-tolboom commented Jun 16, 2023

Thank you for considering contributing to GdUnit4! Make H2? Or new line to make it more explicit

clemens-tolboom commented on issue godotengine/godot#72825

Thu, 2023/06/15 - 9:16pm
clemens-tolboom commented on godotengine/godot#72825 · June 15, 2023 19:16 clemens-tolboom commented Jun 15, 2023

<C++ Source> modules/gdscript/gdscript_vm.cpp:697 @ call() In #75550 we use the build-in GDScript editor which @dakennedyd thinks relates to this…

clemens-tolboom commented on issue godotengine/godot#75550

Thu, 2023/06/15 - 9:12pm
clemens-tolboom commented on godotengine/godot#75550 · June 15, 2023 19:12 clemens-tolboom commented Jun 15, 2023

It was a hot reload/script edit while running ... I do that a lot but thought my anonymous functions caused it. Issue #72825 is only mentioning ext…

clemens-tolboom starred HungryProton/scatter

Tue, 2023/06/13 - 8:07am
clemens-tolboom starred HungryProton/scatter · June 13, 2023 06:07 HungryProton/scatter

Godot engine addon to randomly fill an area with props or other scenes

GDScript 1.3k Updated Jun 13

clemens-tolboom closed a pull request in MikeSchulze/gdUnit4

Mon, 2023/06/12 - 8:35pm
clemens-tolboom closed MikeSchulze/gdUnit4#201 · June 12, 2023 18:35 GD-200: Handle null values on SceneRunner `get_property` #201

To fix this we need to 'know' the scene properties.

+13 -3 2 comments

clemens-tolboom closed a pull request in MikeSchulze/gdUnit4

Mon, 2023/06/12 - 8:32pm
clemens-tolboom closed MikeSchulze/gdUnit4#199 · June 12, 2023 18:32 GD-198: Add `set_property` to SceneRunner. #199

Add set_property to both GdUnitSceneRunner and GdUnitSceneRunnerImpl

+14 -0 2 comments