clemens-tolboom commented on pull request boku-ilen/geodot-plugin#33 Jan 25, 2021 clemens-tolboom commented Jan 25, 2021

We could try manual copy the library from /usr/local/Cellar/gdal/3.2.1/lib/libgdal.dylib

clemens-tolboom commented on issue boku-ilen/geodot-plugin#41 Jan 25, 2021 clemens-tolboom commented Jan 25, 2021

I look cool but is it doable? https://github.com/godotengine/build-containers/blob/master/build.sh is a good starting point for contemplating.

clemens-tolboom opened an issue in boku-ilen/geodot-plugin Jan 25, 2021 Can we mimic Godot build scripts to build all platforms support? #41

Maybe this helps https://github.com/godotengine/godot-build-scripts ? Godot CI is using this to test every PR generating builds in https://github.c…

clemens-tolboom commented on issue boku-ilen/geodot-plugin#36 Jan 25, 2021 clemens-tolboom commented Jan 25, 2021

.gitattributes is key. addons/geodot should be rooted imho I prefer the demo to be in addons/geodot/demo which can be ignored by the user importing …

clemens-tolboom opened a pull request in pytorch/tutorials Jan 25, 2021 Lets make a copyright jump into 2021 #1318

It looks way better to have copyright extends into current year ;-)

+1 -1

clemens-tolboom pushed to patch-1 in clemens-tolboom/tutorials Jan 25, 2021 1 commit to patch-1

• 006cced Lets make a copyright jump into 2021

clemens-tolboom forked clemens-tolboom/tutorials from pytorch/tutorials Jan 25, 2021 pytorch/tutorials

PyTorch tutorials.

Jupyter Notebook 4.6k Updated Jan 25

clemens-tolboom commented on pull request boku-ilen/geodot-plugin#33 Jan 25, 2021 clemens-tolboom commented Jan 25, 2021

Comparing Windows/Linux/Mac directory content only Linux has https://github.com/boku-ilen/geodot-plugin/blob/master/demo/addons/geodot/x11/libgdal.so

clemens-tolboom commented on pull request boku-ilen/geodot-plugin#33 Jan 25, 2021 clemens-tolboom commented Jan 25, 2021

Hmmm ... moving in the demo root makes running the scene crash :-) Registered camera FaceTime HD Camera (Display) with id 4 position 0 at index 3 …

clemens-tolboom commented on pull request boku-ilen/geodot-plugin#33 Jan 25, 2021 clemens-tolboom commented Jan 25, 2021

Just a guess: Could it be that it's expecting libRasterTileExtractor.dylib to be in a directory called build for some reason, but it's actually in…

clemens-tolboom commented on pull request boku-ilen/geodot-plugin#33 Jan 25, 2021 clemens-tolboom commented Jan 25, 2021

I guess I should have created new issues for my remarks ... not sure what comment is what now :( See new issues #38, #39,#40

clemens-tolboom opened an issue in boku-ilen/geodot-plugin Jan 25, 2021 What is env.Append(LINKFLAGS=['/WHOLEARCHIVE']) and should osx have that too? #40

clemens-tolboom opened an issue in boku-ilen/geodot-plugin Jan 25, 2021 The linux includes all <gdal/... ... can't we make this uniform? #39

grep --recursive --after=2 __unix__ .

clemens-tolboom opened an issue in boku-ilen/geodot-plugin Jan 25, 2021 Why are both SConstruct files different for windows? #38

diff src/vector-extractor/SConstruct src/raster-tile-extractor/SConstruct

clemens-tolboom opened an issue in boku-ilen/geodot-plugin Jan 25, 2021 Make sure godot-cpp is build same as our target #37

scons target=debug should build godot-cpp similar. The instructions are not covering switching from debug to release. Can't we add this to main SCo…

clemens-tolboom commented on pull request boku-ilen/geodot-plugin#33 Jan 25, 2021 clemens-tolboom commented Jan 25, 2021

Running scons target=d osgeo_path=/usr/local/Cellar/gdal/3.2.1 solved building. Godot ERROR: open_dynamic_library: Can't open dynamic library: /Use…

clemens-tolboom commented on pull request boku-ilen/geodot-plugin#33 Jan 25, 2021 clemens-tolboom commented Jan 25, 2021

Following the steps above I see one warning g++ -o VectorExtractor.os -c -std=c++17 -fPIC -I/usr/local/Cellar/gdal/3.2.1/include -I. -I/Users/cleme…

clemens-tolboom pushed to feature/support-macos in clemens-tolboom/geodot-plugin Jan 25, 2021 1 commit to feature/support-macos

• 26ef2fe Build libgeodot.dylib.

clemens-tolboom commented on pull request boku-ilen/geodot-plugin#33 Jan 25, 2021 clemens-tolboom commented Jan 25, 2021

I can now compile. Why are both SConstruct files different for windows? diff src/vector-extractor/SConstruct src/raster-tile-extractor/SConstruct …

clemens-tolboom pushed to feature/support-macos in clemens-tolboom/geodot-plugin Jan 25, 2021 1 commit to feature/support-macos

• 669cbd9 Sync the 2 SConstruct files.