clemens-tolboom commented on pull request MikeSchulze/gdUnit3#42 Apr 11, 2021 clemens-tolboom commented Apr 11, 2021

(quick feedback) ./runtest.sh /Applications/Godot_v3.3-rc8_osx.universal.app/Contents/MacOS/Godot arguments 0: /Applications/Godot_v3.3-rc8_osx.uni…

clemens-tolboom commented on pull request MikeSchulze/gdUnit3#42 Apr 11, 2021 clemens-tolboom commented Apr 11, 2021

I've downloaded https://github.com/MikeSchulze/gdUnit3/archive/refs/heads/GD-41.zip which I probably use over next 2 weeks

clemens-tolboom deleted branch feature/add-urandom at clemens-tolboom/DenoWebRTCGroupChat Apr 11, 2021 clemens-tolboom/DenoWebRTCGroupChat

Updated Mar 24

clemens-tolboom commented on pull request ngchianglin/DenoWebRTCGroupChat#2 Apr 11, 2021 clemens-tolboom commented Apr 11, 2021

Thanks ... hope to come back soon with some more ;-)

clemens-tolboom commented on pull request MikeSchulze/gdUnit3#42 Apr 7, 2021 clemens-tolboom commented Apr 7, 2021

Should we move gdUnit.bat into addon/.../bin/ directory? And what about Mac/Linux?

clemens-tolboom commented on pull request MikeSchulze/gdUnit3#42 Apr 7, 2021 clemens-tolboom commented Apr 7, 2021

prefix with dash -ms-flex-positive according to VSCode

clemens-tolboom commented on pull request MikeSchulze/gdUnit3#42 Apr 7, 2021 clemens-tolboom commented Apr 7, 2021

Missing semi colon

clemens-tolboom commented on pull request MikeSchulze/gdUnit3#42 Apr 7, 2021 clemens-tolboom commented Apr 7, 2021

double colon

clemens-tolboom commented on pull request MikeSchulze/gdUnit3#42 Apr 7, 2021 clemens-tolboom commented Apr 7, 2021

Add report dir to .gitignore

clemens-tolboom commented on pull request MikeSchulze/gdUnit3#42 Apr 7, 2021 clemens-tolboom commented Apr 7, 2021

Awesome report :-) Missing duration label Strange hover A gray area appear when hove over column Failure Empty output

clemens-tolboom commented on pull request MikeSchulze/gdUnit3#42 Apr 7, 2021 clemens-tolboom commented Apr 7, 2021

Running our tests godot --script addons/gdUnit3/GdUnitCmdTool.gd -add addons/gdUnit3/test Scanning for test suites in: /Users/clemens/Sites/Godot/…

clemens-tolboom commented on pull request MikeSchulze/gdUnit3#42 Apr 7, 2021 clemens-tolboom commented Apr 7, 2021

godot --script addons/gdUnit3/GdUnitCmdTool.gd -add x should exit early ---------------------------------------------------------------------------…

clemens-tolboom commented on pull request MikeSchulze/gdUnit3#42 Apr 7, 2021 clemens-tolboom commented Apr 7, 2021

Running gd rc7 --script addons/gdUnit3/GdUnitCmdTool.gd (I have 4 versions of Godot) gives --------------------------------------------------------…

clemens-tolboom commented on pull request MikeSchulze/gdUnit3#42 Apr 7, 2021 clemens-tolboom commented Apr 7, 2021

Could we make one the main scene to run projects tests immediately? cd ... godot

clemens-tolboom commented on pull request MikeSchulze/gdUnit3#42 Apr 7, 2021 clemens-tolboom commented Apr 7, 2021

Guess I have to run this addons/gdUnit3/GdUnitCmdTool.gd

clemens-tolboom commented on pull request MikeSchulze/gdUnit3#42 Apr 7, 2021 clemens-tolboom commented Apr 7, 2021

Nitpicking: empty class 3 many whitelines

clemens-tolboom commented on pull request MikeSchulze/gdUnit3#42 Apr 7, 2021 clemens-tolboom commented Apr 7, 2021

My .bat is a little rusty but I prefer all uppercase for for DOS commands Missing new line at end Can't we use .env file to find Godot (long shot …

clemens-tolboom deleted branch feature/gitattributes at clemens-tolboom/gdUnit3 Apr 4, 2021 clemens-tolboom/gdUnit3

Updated Apr 3

clemens-tolboom commented on pull request MikeSchulze/gdUnit3#45 Apr 4, 2021 clemens-tolboom commented Apr 4, 2021

Thanks

clemens-tolboom deleted branch feature/process-example at clemens-tolboom/gdUnit3 Apr 4, 2021 clemens-tolboom/gdUnit3

Updated Apr 3